fix minimum versions of dependencies #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 49.76% 49.74% -0.02%
==========================================
Files 50 50
Lines 3563 3560 -3
==========================================
- Hits 1773 1771 -2
+ Misses 1790 1789 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Why an additional ci yml? |
|
Ultimately because that is how it's done in xarray... Probably because it's not strictly code testing, but I can move it over. |
veni-vidi-vici-dormivi
approved these changes
Aug 30, 2024
|
Thanks - I hope this does not bite you in #501 |
Haha me too but better this way around than the other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.rstDefines minumum versions for all dependencies. Ensures they follow NEP-29 (according to the xarray interpretation). Also updates the current lower bounds. (I decided to use the newest allowed version for all (direct) dependencies. It is of course always allowed to support older versions, but I don't see less upside for this as I once did.)
B.T.W. no need to review the min_deps_check.py script.